Remove duplicated fields definitions by jsoriano · Pull Request #3392 · elastic/integrations

jsoriano · 2022-05-19T17:59:23Z

What does this PR do?

Remove duplicated fields.

This is important to avoid unexpected results, when definitions are different any of them could be applied.

This is also a requirement to use package-spec 1.8.0.

See elastic/package-spec#309.

Related issues

Related to Validate that fields are defined only once per data stream package-spec#309.
Replaces Remove duplicated fields #3316.
Part of Enable check to avoid duplicated fields package-spec#331.

Screenshots

jsoriano · 2022-05-19T17:59:55Z

go.mod

 	sigs.k8s.io/yaml v1.3.0 // indirect
 )
+
+replace github.com/elastic/package-spec => github.com/jsoriano/package-spec v0.0.0-20220519154435-520b485f62c0


To be reverted. Includes elastic/package-spec#338.

elasticmachine · 2022-05-19T20:02:51Z

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-06-08T22:11:23.141+0000
Duration: 93 min 56 sec

Test stats 🧪

Test	Results
Failed	2
Passed	4776
Skipped	7
Total	4785

Test errors

Expand to view the tests failures

`Check integrations / mysql / mysql: check / system test: default (variant: percona_5_7_24) – mysql.slowlog`

Expand to view the error details

 null

Expand to view the stacktrace

 one or more errors found in documents stored in logs-mysql.slowlog-ep data stream: [0] found error.message in event: Provided Grok expressions do not match field value: [time: 0.000051  Lock_time: 0.000021 Rows_sent: 0  Rows_examined: 0\nSET timestamp=1654728872;\nINSERT INTO time_zone_name (Name, Time_zone_id) VALUES ('right/NZ-CHAT', @time_zone_id);]

`Check integrations / mysql / mysql: check / system test: default (variant: mariadb_10_2_23) – mysql.slowlog`

Expand to view the error details

 null

Expand to view the stacktrace

 one or more errors found in documents stored in logs-mysql.slowlog-ep data stream: [0] found error.message in event: Provided Grok expressions do not match field value: [@Host: root[root] @ localhost []  Id:     3\n# Query_time: 0.000021  Lock_time: 0.000000 Rows_sent: 0  Rows_examined: 0\nSET timestamp=1654728973;\nSET @time_zone_id= LAST_INSERT_ID();]

Steps errors

Expand to view the steps failures

`Test integration: aws`

Took 12 min 52 sec . View more details here
Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage

`Boot up the Elastic stack`

Took 2 min 49 sec . View more details here
Description: ../../build/elastic-package stack up -d -v --version 7.15.0

`Test integration: mysql`

Took 18 min 47 sec . View more details here
Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

elasticmachine · 2022-05-24T10:44:51Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`248/248`)	💚
Files	96.69% (`409/423`)	👍 0.123
Classes	96.69% (`409/423`)	👍 0.123
Methods	89.575% (`4219/4710`)	👍 0.686
Lines	89.676% (`76938/85796`)	👎 -0.082
Conditionals	100.0% (`0/0`)	💚

jsoriano · 2022-05-31T10:55:36Z

/test

packages/cisco/docs/README.md

jsoriano · 2022-06-20T08:45:12Z

Closing this by now, we will wait to have something like elastic/package-spec#345, so packages can be updated one by one.

jsoriano added 3 commits May 19, 2022 17:51

Enable validator

ad83007

Remove duplicates

69fc1cd

Update readmes

15663d5

jsoriano self-assigned this May 19, 2022

jsoriano commented May 19, 2022

View reviewed changes

jsoriano added 8 commits May 24, 2022 09:45

Merge remote-tracking branch 'origin/main' into check-duplicated-fields

4b2604e

Fix azure additional details field

989904a

Add missing fields to carbon_black_cloud

d4deb04

Revert changes in types of system fields

839af8e

Revert type changed

4cc72c4

Revert removal of values

58c7331

Revert uneeded change

dd1b08d

Add changelog entries

9cfd76e

This was referenced May 24, 2022

Remove duplicated fields #3316

Closed

Enable check to avoid duplicated fields elastic/package-spec#331

Closed

Merge remote-tracking branch 'origin/main' into check-duplicated-fields

d26a8c0

jsoriano force-pushed the check-duplicated-fields branch from 1bda00e to 2582302 Compare May 30, 2022 15:02

Merge remote-tracking branch 'origin/main' into check-duplicated-fields

2e0a456

jsoriano force-pushed the check-duplicated-fields branch from 2582302 to 2e0a456 Compare May 30, 2022 15:04

jsoriano changed the title ~~Check duplicated fields~~ Remove duplicated fields definitions May 30, 2022

jsoriano added 2 commits May 31, 2022 10:10

Remove more duplicated definitions in AWS

0fa8e87

Remove more duplicated definitions in Cisco Umbrella

821e83d

andrewkroh reviewed May 31, 2022

View reviewed changes

packages/cisco/docs/README.md Show resolved Hide resolved

jsoriano added 3 commits June 8, 2022 18:57

Merge remote-tracking branch 'origin/main' into check-duplicated-fields

c204daa

Fix AWS

bd6ee86

Merge remote-tracking branch 'origin/main' into check-duplicated-fields

a10135e

jsoriano closed this Jun 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove duplicated fields definitions#3392

Remove duplicated fields definitions#3392
jsoriano wants to merge 18 commits intoelastic:mainfrom
jsoriano:check-duplicated-fields

jsoriano commented May 19, 2022

Uh oh!

jsoriano May 19, 2022

Uh oh!

elasticmachine commented May 19, 2022 •

edited

Loading

Build stats

Test stats 🧪

`Check integrations / mysql / mysql: check / system test: default (variant: percona_5_7_24) – mysql.slowlog`

`Check integrations / mysql / mysql: check / system test: default (variant: mariadb_10_2_23) – mysql.slowlog`

`Test integration: aws`

`Boot up the Elastic stack`

`Test integration: mysql`

Uh oh!

elasticmachine commented May 24, 2022 •

edited

Loading

Uh oh!

jsoriano commented May 31, 2022

Uh oh!

Uh oh!

jsoriano commented Jun 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jsoriano commented May 19, 2022

What does this PR do?

Related issues

Screenshots

Uh oh!

jsoriano May 19, 2022

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented May 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Tests Failed

Build stats

Test stats 🧪

Test errors

Check integrations / mysql / mysql: check / system test: default (variant: percona_5_7_24) – mysql.slowlog

Check integrations / mysql / mysql: check / system test: default (variant: mariadb_10_2_23) – mysql.slowlog

Steps errors

Test integration: aws

Boot up the Elastic stack

Test integration: mysql

🤖 GitHub comments

Uh oh!

elasticmachine commented May 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌐 Coverage report

Uh oh!

jsoriano commented May 31, 2022

Uh oh!

Uh oh!

jsoriano commented Jun 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

elasticmachine commented May 19, 2022 •

edited

Loading

`Check integrations / mysql / mysql: check / system test: default (variant: percona_5_7_24) – mysql.slowlog`

`Check integrations / mysql / mysql: check / system test: default (variant: mariadb_10_2_23) – mysql.slowlog`

`Test integration: aws`

`Boot up the Elastic stack`

`Test integration: mysql`

elasticmachine commented May 24, 2022 •

edited

Loading